fix: button group (dropdown) spacing #7393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the Button component in the Twenty front-end, adjusting the horizontal padding of buttons from 2 spacing units to 1.5 spacing units.
- Reduced horizontal padding in
Button.tsxfromtheme.spacing(2)totheme.spacing(1.5) - Change affects all button variants (primary, secondary, tertiary) and sizes (small, medium)
- May impact button group layouts and overall UI consistency
- Potential need to update related components like
ButtonGroupfor alignment - Consider reviewing usage in stories (e.g.,
ButtonGroup.stories.tsx,MainButton.stories.tsx) to ensure visual consistency
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
Hi @prakhar1535, |
|
sure @ehconitin will raise it from a feature branch |
|
hey @ehconitin raised a new pr #7409 against the same issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.